Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include log.source.address for unparseable syslog messages #13274

Closed
wants to merge 1 commit into from

Conversation

candlerb
Copy link
Contributor

Fixes #13268

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@jsoriano
Copy link
Member

jsoriano commented Sep 4, 2019

ok to test

@strawgate
Copy link
Contributor

Can this move forward? This is causing us significant problems in our environment

@jsoriano
Copy link
Member

This will need a changelog entry.

@ph could you also take a look to this change? Thanks!

@ph
Copy link
Contributor

ph commented Oct 23, 2019

LGTM, need a changelog entry and a test

@strawgate
Copy link
Contributor

Not having this is causing issues in our environment as its basically impossible to tell where the log message that is invalid came from...

@jsoriano
Copy link
Member

jsoriano commented Jan 9, 2020

@candlerb could you add the test and the changelog entry? If you don't have time it is ok, we can also continue with this change.

Thanks!

@candlerb
Copy link
Contributor Author

candlerb commented Jan 9, 2020

Sorry, at the time I couldn't see an easy way to add a test to this without big refactoring, in a codebase I wasn't familiar with.

@jsoriano
Copy link
Member

I am continuing with this in #15453.

@candlerb I will add you as co-author, thanks for starting with this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

filebeat syslog input: missing log.source.address when message not parsed
5 participants